ShuttleSystem: FTL docking functions accept and check docking types #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatston3
added
S: Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds DockType to various FTL docking functions in ShuttleSystem.
Why / Balance
Generally, when you want to dock with a station (e.g. on shuttle purchase) you really care about having a way for people/supplies to board the ship, not gases.
Not a huge deal currently, but avoiding possible future annoyance - if you had a ship with one entry/exit port with an airlock and a gaslock side by side, and the dock selection matched up with the gaslock somehow, and there wasn't an adjacent airlock, you'd have to break in through the wall.
Missed this in the gas PR.
How to test
Bonus points: map a grid with only gaslocks and buy a shuttle - it should show up in space.
Media
From the test procedure, a Gasbender was purchased and docked with the Expeditionary Lodge. The gaslock is undocked (no yellow lights visible).
Requirements
Breaking changes
Changelog
Minor feature, little effect in-game at the moment.